[1/4] Move methods under the redfishwrapper for reuse #369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables other providers to reuse the Inventory method and customise its use based on the vendor/model
The FirmwareUpload and related methods in redfishwrapper are more generic and can be re-used by providers with OEM specific update parameters. Having these methods in the redfish provider makes it cumbersome to maintain and extend.
…pper The wrapper provides implementations other providers can call into for code reuse
…oved method internals into the redfishwrapper so they can be reused by other providers
This helps with debugging failed tasks
joelrebel
changed the title
coffeefreak101
approved these changes
Nov 27, 2023
ofaurax
requested changes
Nov 28, 2023
…thod should be generic
…rSet(), PowerStateGet() methods
…oadedAndInitiate(), FirmwareInstallStatus() methods
[4/4] Redfish dell
[3/4] redfish/GetBiosConfiguration: move tests and fixtures
[2/4] Supermicro redfish methods
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## devel-rework-redfishwrapper #369 +/- ##
===============================================================
- Coverage 44.60% 43.87% -0.74%
===============================================================
Files 61 59 -2
Lines 5206 5042 -164
===============================================================
- Hits 2322 2212 -110
+ Misses 2628 2608 -20
+ Partials 256 222 -34 ☔ View full report in Codecov by Sentry. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR implement/change/remove?
This is to allow each vendor/OEM provider to re-use and extend these methods.
Checklist